Skip to content

Optimise the method for stripe removal#202

Closed
namannimmo10 wants to merge 6 commits into
mainfrom
stripe
Closed

Optimise the method for stripe removal#202
namannimmo10 wants to merge 6 commits into
mainfrom
stripe

Conversation

@namannimmo10

@namannimmo10 namannimmo10 commented Mar 5, 2025

Copy link
Copy Markdown
Member

Changes made:

  • avoid creating an index array (matindex)
  • avoid stacking arrays together
  • avoid making extra copies

@namannimmo10 namannimmo10 added the run-zenodo-tests Run Zenodo tests for each PR label Mar 5, 2025
Comment thread zenodo-tests/test_prep/test_stripe.py Outdated
@neon60

neon60 commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator

@namannimmo10 Could you please share the benefits of your changes in the issue description?
Memory usage reduction? Performance improvement? Do you have numbers?

@neon60

neon60 commented Mar 20, 2025

Copy link
Copy Markdown
Collaborator

@namannimmo10 Could you please share the benefits of your changes in the issue description? Memory usage reduction? Performance improvement? Do you have numbers?

Got my answer.

@dkazanc

dkazanc commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

we've done some optimisation for the method in #257 , so I'll close this for now

@dkazanc dkazanc closed this Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-zenodo-tests Run Zenodo tests for each PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants